To: vim_dev@googlegroups.com
Subject: Patch 9.0.0346
Fcc: outbox
From: Bram Moolenaar <Bram@moolenaar.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
------------

Patch 9.0.0346
Problem:    :horizontal modifier not fully supported.
Solution:   Also use :horizontal for completion and user commands.
            (closes #11025)
Files:      runtime/doc/map.txt, src/cmdexpand.c, src/ex_docmd.c,
            src/usercmd.c, src/testdir/test_cmdline.vim,
            src/testdir/test_usercommands.vim


*** ../vim-9.0.0345/runtime/doc/map.txt	2022-07-03 13:15:57.988497914 +0100
--- runtime/doc/map.txt	2022-09-01 12:51:35.277377189 +0100
***************
*** 1719,1729 ****
  					*<mods>* *<q-mods>* *:command-modifiers*
  	<mods>  The command modifiers, if specified. Otherwise, expands to
  		nothing. Supported modifiers are |:aboveleft|, |:belowright|,
! 		|:botright|, |:browse|, |:confirm|, |:hide|, |:keepalt|,
! 		|:keepjumps|, |:keepmarks|, |:keeppatterns|, |:leftabove|,
! 		|:lockmarks|, |:noautocmd|, |:noswapfile| |:rightbelow|,
! 		|:sandbox|, |:silent|, |:tab|, |:topleft|, |:unsilent|,
! 		|:verbose|, and |:vertical|.
  		Note that |:filter| is not supported.
  		Examples: >
  		    command! -nargs=+ -complete=file MyEdit
--- 1724,1734 ----
  					*<mods>* *<q-mods>* *:command-modifiers*
  	<mods>  The command modifiers, if specified. Otherwise, expands to
  		nothing. Supported modifiers are |:aboveleft|, |:belowright|,
! 		|:botright|, |:browse|, |:confirm|, |:hide|, |:horizontal|,
! 		|:keepalt|, |:keepjumps|, |:keepmarks|, |:keeppatterns|,
! 		|:leftabove|, |:lockmarks|, |:noautocmd|, |:noswapfile|
! 		|:rightbelow|, |:sandbox|, |:silent|, |:tab|, |:topleft|,
! 		|:unsilent|, |:verbose|, and |:vertical|.
  		Note that |:filter| is not supported.
  		Examples: >
  		    command! -nargs=+ -complete=file MyEdit
*** ../vim-9.0.0345/src/cmdexpand.c	2022-08-26 19:58:45.947700271 +0100
--- src/cmdexpand.c	2022-09-01 12:51:39.553375664 +0100
***************
*** 1776,1781 ****
--- 1776,1782 ----
  	case CMD_folddoclosed:
  	case CMD_folddoopen:
  	case CMD_hide:
+ 	case CMD_horizontal:
  	case CMD_keepalt:
  	case CMD_keepjumps:
  	case CMD_keepmarks:
*** ../vim-9.0.0345/src/ex_docmd.c	2022-08-31 17:48:05.711547579 +0100
--- src/ex_docmd.c	2022-09-01 12:51:39.553375664 +0100
***************
*** 2455,2460 ****
--- 2455,2461 ----
  	    case CMD_final:
  	    case CMD_help:
  	    case CMD_hide:
+ 	    case CMD_horizontal:
  	    case CMD_ijump:
  	    case CMD_ilist:
  	    case CMD_isearch:
*** ../vim-9.0.0345/src/usercmd.c	2022-07-26 17:23:35.809981769 +0100
--- src/usercmd.c	2022-09-01 12:51:39.557375660 +0100
***************
*** 1443,1448 ****
--- 1443,1451 ----
      // :vertical
      if (cmod->cmod_split & WSP_VERT)
  	result += add_cmd_modifier(buf, "vertical", multi_mods);
+     // :horizontal
+     if (cmod->cmod_split & WSP_HOR)
+ 	result += add_cmd_modifier(buf, "horizontal", multi_mods);
      return result;
  }
  
*** ../vim-9.0.0345/src/testdir/test_cmdline.vim	2022-08-30 21:46:03.657214444 +0100
--- src/testdir/test_cmdline.vim	2022-09-01 12:51:39.557375660 +0100
***************
*** 1078,1083 ****
--- 1078,1087 ----
    call feedkeys(":all abc\<C-A>\<C-B>\"\<CR>", 'xt')
    call assert_equal("\"all abc\<C-A>", @:)
  
+   " completion for :wincmd with :horizontal modifier
+   call feedkeys(":horizontal wincm\<C-A>\<C-B>\"\<CR>", 'xt')
+   call assert_equal("\"horizontal wincmd", @:)
+ 
    " completion for a command with a command modifier
    call feedkeys(":topleft new\<C-A>\<C-B>\"\<CR>", 'xt')
    call assert_equal("\"topleft new", @:)
*** ../vim-9.0.0345/src/testdir/test_usercommands.vim	2022-07-03 13:15:57.988497914 +0100
--- src/testdir/test_usercommands.vim	2022-09-01 12:51:39.557375660 +0100
***************
*** 103,108 ****
--- 103,112 ----
    call assert_equal('vertical', g:mods)
    vert MyCmd
    call assert_equal('vertical', g:mods)
+   horizontal MyCmd
+   call assert_equal('horizontal', g:mods)
+   hor MyCmd
+   call assert_equal('horizontal', g:mods)
  
    aboveleft belowright botright browse confirm hide keepalt keepjumps
  	      \ keepmarks keeppatterns lockmarks noautocmd noswapfile silent
*** ../vim-9.0.0345/src/version.c	2022-09-01 12:22:19.751659183 +0100
--- src/version.c	2022-09-01 12:53:18.012823536 +0100
***************
*** 709,710 ****
--- 709,712 ----
  {   /* Add new patch number below this line */
+ /**/
+     346,
  /**/

-- 
BLACK KNIGHT: I'm invincible!
ARTHUR:       You're a looney.
                 "Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD

 /// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net   \\\
///                                                                      \\\
\\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///